First Last Prev Next    No search results available
Details
: ESR 2018 readiness - Make SmartTemplate4 compatible with ...
Bug#: 26494
: smarttemplate4
: General
Status: RESOLVED
Resolution: FIXED
: PC
: Windows NT
: unspecified
: P2
: normal
: ---

:
:
:
:
:
  Show dependency tree - Show dependency graph
People
Reporter: Axel Grude <axel.grude@gmail.com>
Assigned To: Axel Grude <axel.grude@gmail.com>
:

Attachments
1.5 prerelease 179 (455.64 KB, application/x-xpinstall)
2018-02-28 04:05, Axel Grude
no flags Details
1.5 prerelease 189 (463.75 KB, application/x-xpinstall)
2018-04-11 03:58, Axel Grude
no flags Details
1.5 prerelease 209 (493.82 KB, application/x-xpinstall)
2018-04-26 04:25, Axel Grude
no flags Details
1.5.2 prerelease 4 (496.22 KB, application/x-xpinstall)
2018-05-04 08:13, Axel Grude
no flags Details
1.6 prerelease 247 (505.56 KB, application/x-xpinstall)
2018-11-10 01:08, Axel Grude
no flags Details


Note

You need to log in before you can comment on or make changes to this bug.

Related actions


Description:   Opened: 2018-02-28 04:00
With the  latest changes in the code base (dropping inline options / option
buttons in the Extension manager) for Thunderbird 60 the dialogs do not display
as expected: no Ok / Cancel buttons, no background / title bars, too largee
fonts and no background. 

There are also some problems with the styling of toolbar buttons and statusbar
buttons. The necessary code changes are summarized here:

https://wiki.mozilla.org/Thunderbird/Add-ons_Guide_57

in particular:

# for (x in fixIterator(obj)) (removed due to removal of __iterator__) --
replacement: for (x of fixIterator(obj))

# nsILocalFile -- replacement: nsIFile

# The bindings for the toolbar customization have moved from "global" to
"messenger" - changes in chrome.manifest:
style chrome://global/content/customizeToolbar.xul    chrome://.../skin/...
.css appversion<59.0a1
style chrome://messenger/content/customizeToolbar.xul chrome://.../skin/...
.css appversion>=59.0a1

# CSS for the preference dialogs has moved from Mozilla core to Thunderbird.
add <?xml-stylesheet type="text/css"
href="chrome://messenger/skin/preferences/preferences.css"?>

# The statusbarpanel-iconic and statusbarpanel-iconic-text was removed, use
toolbarbutton instead
------- Comment #1 From Axel Grude 2018-02-28 04:05:58 -------
Created an attachment (id=8398) [details]
1.5 prerelease 179

Tested with Thunderbird Daily 60.0a1 (2018-02-27) (32-bit)
------- Comment #2 From Axel Grude 2018-03-09 00:34:06 -------
*** Bug 26446 has been marked as a duplicate of this bug. ***
------- Comment #3 From Thanos 2018-04-11 01:19:32 -------
(In reply to comment #1)
> Created an attachment (id=8398) [details] [details]
> 1.5 prerelease 179
> 
> Tested with Thunderbird Daily 60.0a1 (2018-02-27) (32-bit)
> 

Prerelease worked fine with Thunderbird Beta 60.0b1. It also worked fine with
Beta 60.0b2 until today. Today thunderbird developers decided to disable all
incompatible addons (and smarttemplate4 1.5 pre-179 is marked as
incompatible)...
------- Comment #4 From Axel Grude 2018-04-11 03:58:19 -------
Created an attachment (id=8431) [details]
1.5 prerelease 189

compatibility version bumped up to 60.* - sorry for the iconvenience. I am
generally quite cautious with my max versions in ST4, so the preevious version
was set to 58.*

1.5 will be released shortly, I still have to make the release video!

Full version history:
http://smarttemplate4.mozdev.org/version.html#1.5
------- Comment #5 From Thanos 2018-04-12 05:38:10 -------
(In reply to comment #4)
> Created an attachment (id=8431) [details] [details]
> 1.5 prerelease 189
> 
> compatibility version bumped up to 60.* - sorry for the iconvenience. I am
> generally quite cautious with my max versions in ST4, so the preevious version
> was set to 58.*
> 
> 1.5 will be released shortly, I still have to make the release video!
> 
> Full version history:
> http://smarttemplate4.mozdev.org/version.html#1.5
> 

sweet!
thank you
------- Comment #6 From Axel Grude 2018-04-12 06:18:47 -------
By the way if you want to support development / support, the shop for getting a
Pro License is now open. Will set the bug to FIXED once I release (within 2
weeks)
------- Comment #7 From Axel Grude 2018-04-26 04:25:16 -------
Created an attachment (id=8439) [details]
1.5 prerelease 209

Make sure the expanded / contracted status of the setting dialog is remembered
Close settings dialog when clicking on links in the support tab 
------- Comment #8 From Axel Grude 2018-04-27 04:32:30 -------
Setting to Resolved Fixed with officially Release 1.5
------- Comment #9 From Axel Grude 2018-05-04 08:13:20 -------
Created an attachment (id=8448) [details]
1.5.2 prerelease 4

Reopening this bug again because of [Bug 26524] - fix in 1.5.2 pre 4
------- Comment #10 From Axel Grude 2018-11-10 01:08:07 -------
Created an attachment (id=8553) [details]
1.6 prerelease 247

Latest Prerelease, fully compatible with Thunderbird 60.3
------- Comment #11 From Axel Grude 2019-07-28 07:09:55 -------
Finally Resolved with Version 2.0 - 23/12/2018

First Last Prev Next    No search results available