First Last Prev Next    No search results available
Details
: ESR 2018 readiness - Make quickFilters compatible tB 60
Bug#: 26488
: quickFilters
: General
Status: RESOLVED
Resolution: FIXED
: PC
: Windows NT
: unspecified
: P2
: critical
: ---

:
:
:
:
:
  Show dependency tree - Show dependency graph
People
Reporter: Axel Grude <axel.grude@gmail.com>
Assigned To: Axel Grude <axel.grude@gmail.com>

Attachments
3.5 prerelease 86 (384.56 KB, application/x-xpinstall)
2018-02-24 10:48, Axel Grude
no flags Details
3.5 prerelease 102 (385.68 KB, application/x-xpinstall)
2018-04-11 04:15, Axel Grude
no flags Details


Note

You need to log in before you can comment on or make changes to this bug.

Related actions


Description:   Opened: 2018-02-24 10:23
With the  latest changes in the code base (dropping inline options / option
buttons in the Extension manager) for Thunderbird 60 the dialogs do not display
as expected: no Ok / Cancel buttons, no background / title bars, too largee
fonts and no background. 

There are also some problems with the styling of toolbar buttons and statusbar
buttons. The necessary code changes are summarized here:

https://wiki.mozilla.org/Thunderbird/Add-ons_Guide_57

in particular:

# for (x in fixIterator(obj)) (removed due to removal of __iterator__) --
replacement: for (x of fixIterator(obj))

# nsILocalFile -- replacement: nsIFile

# The bindings for the toolbar customization have moved from "global" to
"messenger" - changes in chrome.manifest:
style chrome://global/content/customizeToolbar.xul    chrome://.../skin/...
.css appversion<59.0a1
style chrome://messenger/content/customizeToolbar.xul chrome://.../skin/...
.css appversion>=59.0a1

# CSS for the preference dialogs has moved from Mozilla core to Thunderbird.
add <?xml-stylesheet type="text/css"
href="chrome://messenger/skin/preferences/preferences.css"?>

# The statusbarpanel-iconic and statusbarpanel-iconic-text was removed, use
toolbarbutton instead
------- Comment #1 From Axel Grude 2018-02-24 10:48:10 -------
Created an attachment (id=8394) [details]
3.5 prerelease 86

Tested with Thunderbird Daily 60.0a1 (2018-02-24) (32-bit)
------- Comment #2 From Axel Grude 2018-04-11 04:15:57 -------
Created an attachment (id=8433) [details]
3.10 prerelease 102

Added warnings about incompatible license if a license for a different Add-on
is entered  (licenses must start with QF)

bumped max version to 60.* to be ESR compatible
------- Comment #3 From Axel Grude 2018-04-11 04:16:47 -------
(From update of attachment 8394 [details])
marked this one obsolete - 60 beta requires strict compatibility. please
install 3.5 pre 102
------- Comment #4 From Axel Grude 2018-04-11 05:18:26 -------
(From update of attachment 8433 [details])
corrected title
------- Comment #5 From Axel Grude 2019-05-17 04:23:11 -------
Implemented Version 3.5 Released May 3, 2018 

First Last Prev Next    No search results available