First Last Prev Next    No search results available
Details
: Thunderbird 52 - Forwarding an email adds empty paragraph...
Bug#: 26356
: smarttemplate4
: General
Status: RESOLVED
Resolution: FIXED
: PC
: Windows NT
: unspecified
: P2
: normal
: ---

:
:
:
:
:
  Show dependency tree - Show dependency graph
People
Reporter: Axel Grude <axel.grude@gmail.com>
Assigned To: Axel Grude <axel.grude@gmail.com>
:

Attachments
1.5 prerelease 26 (389.16 KB, application/x-xpinstall)
2017-04-04 05:05, Axel Grude
no flags Details
1.5 prerelease 42 (389.53 KB, application/x-xpinstall)
2017-06-07 05:29, Axel Grude
no flags Details


Note

You need to log in before you can comment on or make changes to this bug.

Related actions


Description:   Opened: 2017-04-04 05:03
From Thunderbird 52 when forwarding emaill as inline text, an unwanted empty
paragraph is added to the top of the email.
------- Comment #1 From Axel Grude 2017-04-04 05:05:40 -------
Created an attachment (id=8280) [details]
1.5 prerelease 26

This version bypasses the NotifyComposeBodyReady listener but only for the case
where gComposeType == Components.interfaces.nsIMsgCompType.ForwardInline

Still needs to be tested in Postbox / SeaMonkey!
------- Comment #2 From reaganf2 2017-06-02 19:08:46 -------
I'm running Thunderbird 52.1.1 with SmartTemplate4 1.5pre20.
Since my upgrade to Thunderbird 52, forwarding an email results in an extra
<br> above the <div id="smartTemplate4-template"> line of the forward template.
Is there any way this extra <br> could be removed?
For instance, here is my forward template:

<style>
  a:link {color: red !important}
  p {font-family: serif !important; font-size: 17px !important; margin: 12px
4px 12px 4px !important;}
  li {font-family: serif !important; font-size: 17px !important;}
  th {font-family: serif !important; font-size: 17px !important;}
  td {font-family: serif !important; font-size: 17px !important;}
  .moz-forward-container {
    font-family: serif !important;
    font-size: 17px !important;
  }
</style>
<div style="font-family:serif; font-size: 17px;">
  <p>%cursor%</p>
  %sig%
</div>

And here is the HTML code created when forwarding an email:
(Note the <br> in the 6th line)

<html>
  <head>
    <meta http-equiv="content-type" content="text/html; charset=windows-1252">
  </head>
  <body smarttemplateinserted="true" text="#333333" bgcolor="#FFFFFF">
    <br>
    <div id="smartTemplate4-template">
      <style>
  a:link {color: red !important}
  p {font-family: serif !important; font-size: 17px !important; margin: 12px
4px 12px 4px !important;}
  li {font-family: serif !important; font-size: 17px !important;}
  th {font-family: serif !important; font-size: 17px !important;}
  td {font-family: serif !important; font-size: 17px !important;}
  .moz-forward-container {
    font-family: serif !important;
    font-size: 17px !important;
  }
</style>
      <div style="font-family:serif; font-size: 17px;">
        <p><br>
        </p>
        <p>Signature</p>
      </div>
    </div>
------- Comment #3 From Axel Grude 2017-06-07 05:29:53 -------
Created an attachment (id=8297) [details]
1.5 prerelease 42

Can't reproduce the extra br - make sure you set St4 Advanced > Global Settings
Mail Content: Number of line breaks at top: 0

The attached version makes using the template while forwarding work again
(previous fix seems to have disabled the template altogether)
------- Comment #4 From reaganf2 2017-06-07 16:45:31 -------
Thanks Axel. I can confirm that the extra <br> does not appear when using
SmartTemplate4 1.5 prerelease 42.
------- Comment #5 From Axel Grude 2018-04-27 04:32:21 -------
Setting to Resolved Fixed with official Release 1.5

First Last Prev Next    No search results available