Bugzilla@Mozdev – Bug 26257
Default quote header not removed in complex Stationery
Last modified: 2016-07-20 10:22:00
You need to log in before you can comment on or make changes to this bug.
If the default quote header ("On 10/05/2016 Axel wrote") is nested within a deeper structure such as a nested html element within a Stationery file, it is not removed even though the option [x] use instead of quote header is selected. At the moment the quote headers (<div class="-moz-cite-prefix">) are only removed if they are on the highest level within the <body> tag.
In addition, any stationery not containing the %quoteHeader% replacement variable also currently keeps the old header, which is not good behavior - it should honor the settings in the ST4 template dialog. [x] use instead of quote header should always work (as long there is a non-empty replacement header given)
Created an attachment (id=8201) [details] SmartTemplate 1.3 prerelease 41 Prerelease which behaves better and actually replaces the default quote header with the one specified in SmartTemplate4 even when Stationery is used, and even if there is no %quoteHeader% variable in the Stationery. To avoid _always_ replacing, the setting can be disabled: extensions.smartTemplate4.stationery.forceReplaceQuoteHeader = false by right-clicking the "Support Stationery Addon" setting in ST4. I think most people will prefer the new more aggressive behavior so it is enabled by default and the setting is hidden. The patch also attempts to delete any unnecessary content between the new quote header and the first block quote, leading to a cleaner result.
Created an attachment (id=8204) [details] SmartTemplate 1.3 prerelease 48 Some improvements added which avoid taking too much into the <p> tag and accidentally nesting multiple <p> tags.
Resolved in Release 1.3 - 11/07/2016