First Last Prev Next    No search results available
Details
: "Move To" context menu entry not working in Tb 45.0
Bug#: 26200
: quickFilters
: General
Status: RESOLVED
Resolution: FIXED
: PC
: Windows NT
: unspecified
: P2
: major
: ---

:
:
:
:
:
  Show dependency tree - Show dependency graph
People
Reporter: Axel Grude <axel.grude@gmail.com>
Assigned To: Axel Grude <axel.grude@gmail.com>

Attachments
quickFilters 3.2 Prerelease 3 (288.04 KB, application/x-xpinstall)
2016-04-21 12:52, Axel Grude
no flags Details
quickFilters 3.2 Prerelease 17 (288.37 KB, application/x-xpinstall)
2016-06-06 05:36, Axel Grude
no flags Details


Note

You need to log in before you can comment on or make changes to this bug.

Related actions


Description:   Opened: 2016-04-20 11:54
In Thunderbird  45.0 with quickFilters enabled, the context menu in the message
pane (Move To > folder) does not work anymore. It does work if quickFilters is
disabled.
------- Comment #1 From Axel Grude 2016-04-21 04:50:33 -------
Apparently the wrapped function MsgMoveMessage is being called recursively. I
see this when I enable debugging with the switch:

extensions.quickfilters.debug.msgMove

I am getting an endless stream of log messages which looks to me like the same
procedure is called over and over again:


 {MSGMOVE} 12:47:37.548  [0 ms]   
 setTimeout(..) for final move / copy call
 ----------
quickFilters {MSGMOVE} 12:47:37.548  [0 ms]   
After original Move/CopyMessage.]]
 ----------
quickFilters {MSGMOVE} 12:47:38.21  [473 ms]   
Executing original MoveMessage [[
 ----------
quickFilters {MSGMOVE} 12:47:38.22  [1 ms]   
 quickFilters.executeMoveMessage == quickFilters.MsgMove_Wrapper :false
 ----------
quickFilters {MSGMOVE} 12:47:38.22  [0 ms]   
Executing wrapped MsgMoveMessage
 ----------
quickFilters {MSGMOVE} 12:47:38.22  [0 ms]   
 setTimeout(..) for final move / copy call
 ----------
quickFilters {MSGMOVE} 12:47:38.22  [0 ms]   
After original Move/CopyMessage.]]
 ----------
quickFilters {MSGMOVE} 12:47:38.473  [451 ms]   
Executing original MoveMessage [[
 ----------
quickFilters {MSGMOVE} 12:47:38.473  [0 ms]   
 quickFilters.executeMoveMessage == quickFilters.MsgMove_Wrapper :false
 ----------
quickFilters {MSGMOVE} 12:47:38.473  [0 ms]   
Executing wrapped MsgMoveMessage
------- Comment #2 From Axel Grude 2016-04-21 06:12:39 -------
After getting rid of the recall - apparently this function calls MsgMoveMessage
in the Thunderbird module mailWindowsOverlay.js

it passes is the destination folder correctly:

function MsgMoveMessage(aDestFolder)
{
  gFolderDisplay.hintAboutToDeleteMessages();
  gDBView.doCommandWithFolder(nsMsgViewCommandType.moveMessages, aDestFolder);
  Services.prefs.setCharPref("mail.last_msg_movecopy_target_uri",
aDestFolder.URI);
  Services.prefs.setBoolPref("mail.last_msg_movecopy_was_move", true);
}

the big question is why gDBView.doCommandWithFolder doesn't do anything...
------- Comment #3 From Axel Grude 2016-04-21 06:13:07 -------
After getting rid of the recall - apparently this function calls MsgMoveMessage
in the Thunderbird module mailWindowsOverlay.js

it passes is the destination folder correctly:

function MsgMoveMessage(aDestFolder)
{
  gFolderDisplay.hintAboutToDeleteMessages();
  gDBView.doCommandWithFolder(nsMsgViewCommandType.moveMessages, aDestFolder);
  Services.prefs.setCharPref("mail.last_msg_movecopy_target_uri",
aDestFolder.URI);
  Services.prefs.setBoolPref("mail.last_msg_movecopy_was_move", true);
}

the big question is why gDBView.doCommandWithFolder doesn't do anything...
------- Comment #4 From Axel Grude 2016-04-21 12:52:36 -------
Created an attachment (id=8171) [details]
quickFilters 3.2 Prerelease 3

This make the endless calling loop go away. Also, I think the move to is back
to working.
------- Comment #5 From Axel Grude 2016-06-06 05:36:18 -------
Created an attachment (id=8197) [details]
quickFilters 3.2 Prerelease 17

Just a newer version with some added bug fixes so we are all testing the same
things.
------- Comment #6 From Axel Grude 2017-03-24 07:23:02 -------
Fixed in Release 3.2

First Last Prev Next    No search results available