Created an attachment (id=7989) [details]
Email example showing smarttemplate setting in browser

Windows 7, Seamonkey 2.32, Smarttemplate .0.9.6

Smarttemplate setting to replace default Reply header is completely ignored.
I tried removing and reinstalling the add-on without successful result.
I tried reinstalling Seamonkey without successful result.

I don't know exactly when this add-on stopped working.
Checking back on my Sent folder emails, it looks like around 1/13/2015 it
stopped.  I am not sure but think it coincides with the latest Seamonkey
update.

Created an attachment (id=7990) [details]
reply to email examply showing smarttemplate settings are ignored

Created an attachment (id=7991) [details]
Example of last day smarttemplate reply header worked for me

The template appears to have stopped replacing the default on 1/13.
Seamonkey had been updated around that time, but I hadn't really kept track of
the missing template headers.   I noticed it today.

Here's the console2 output during the reply of the sample email in the
attachments.
I tried using the right-click in the smarttemplate debug options, but
right-click on the debug selection was ignored.

Hopefully, this console2 debug info will help uncover the problem.
Thanks

=============================================================================
Console2 Output
=============================================================================

Warning: TypeError: setting a property that has only a getter
 ----------
Warning: TypeError: setting a property that has only a getter
 ----------
Warning: TypeError: setting a property that has only a getter
 ----------
Error: TypeError: redeclaration of variable versionLabel
Source file: chrome://smarttemplate4/content/smartTemplate-util.js
Line: 268, Column: 9
Source code:
     let versionLabel = window.document.getElementById("smartTemplate
 ----------
Warning: ReferenceError: reference to undefined property SmartTemplate4.Util
Source file: chrome://smarttemplate4/content/smartTemplate-main.js
Line: 446
 ----------
Error: TypeError: SmartTemplate4.Util is undefined
Source file: chrome://smarttemplate4/content/smartTemplate-main.js
Line: 446
 ----------
Warning: window.controllers is deprecated. Do not use it for UA detection.
Source file: chrome://editor/content/ComposerCommands.js
Line: 198

=============================================================================
End of output
=============================================================================

(In reply to comment #2)
> Created an attachment (id=7991) [details] [details]
> Example of last day smarttemplate reply header worked for me
> 
> The template appears to have stopped replacing the default on 1/13.
> Seamonkey had been updated around that time, but I hadn't really kept track of
> the missing template headers.   I noticed it today.
> 

Could you paste (as text) your template and quote headers please? I did some
tests with SeaMonkey 2.31 and noticed a problem with %shortdate% so far.

If you attach any error logs please attach them as text (not images) as this is
easier to parse.

Good news - I just updated SeaMonkey to 2.32 and could reproduce the probem.

I am pretty sure it is caused by the changes in 

https://bugzilla.mozilla.org/show_bug.cgi?id=1001090#c196

landing in the SeaMonkey code base. Will upload a patch soon.

(In reply to comment #4)
> (In reply to comment #2)
> > Created an attachment (id=7991) [details] [details] [details]
> > Example of last day smarttemplate reply header worked for me
> > 
> > The template appears to have stopped replacing the default on 1/13.
> > Seamonkey had been updated around that time, but I hadn't really kept track of
> > the missing template headers.   I noticed it today.
> > 
> 
> Could you paste (as text) your template and quote headers please? I did some
> tests with SeaMonkey 2.31 and noticed a problem with %shortdate% so far.
> 
> If you attach any error logs please attach them as text (not images) as this is
> easier to parse.
> 

Reply Quote Header:

<b>Subject</b>: %subject%
<b>Date:</b> %X:=sent% %n%/%d%/%Y% %l%:%M%:%S% %p%
<b>From:</b> %from(mail)%
<b>To:</b> %to(mail)%
[[<b>Cc:</b> %cc(mail)%]] 

There is no Template content.

Hope this helps

Created an attachment (id=7992) [details]
0.9.6.1 prerelease 35

Here is a quickfix. please test thoroughly.

Created an attachment (id=7993) [details]
Results of prerelease patch on original sample email

(In reply to comment #7)
> Created an attachment (id=7992) [details] [details]
> 0.9.6.1 prerelease 35
> 
> Here is a quickfix. please test thoroughly.
> 

Test of prerelease patch has returned functionality.  However I noticed
something peculiar, for my original test email, the quoted original message was
correctly positioned below the reply entry point.  See attachment image.

When I tried replying to the bugzilla email, the quoted original message was
incorrectly placed above the Reply entry point.  This seems like it may be an
unrelated issue to this bug.  See attachment image.

Created an attachment (id=7994) [details]
Some email replies have quote incorrectly positioned at top

(In reply to comment #7)
> Created an attachment (id=7992) [details] [details]
> 0.9.6.1 prerelease 35
> 
> Here is a quickfix. please test thoroughly.
> 

Replyall function appears to ignore multiple CC: and TO: in original quote
header copy.

(In reply to comment #11)
> (In reply to comment #7)
> > Created an attachment (id=7992) [details] [details] [details]
> > 0.9.6.1 prerelease 35
> > 
> > Here is a quickfix. please test thoroughly.
> > 
> 
> Replyall function appears to ignore multiple CC: and TO: in original quote
> header copy.
> 

I attached a sample email of this problem and the reply email for the sample an
example.

It appears that each to addressee is replaced by the same address.

Created an attachment (id=7995) [details]
Sample email with multiple addressees

Created an attachment (id=7996) [details]
Sample email REPLY with multiple addresses

Instead of copying the single person replied to, the same address is used
multiple times for each addressee

Created an attachment (id=7997) [details]
Sample email REPLYALL to multiple addressees

Only one addressee is copied repeatedly to the Reply quote for the number
original addressees.

(In reply to comment #11)
> (In reply to comment #7)
> > Created an attachment (id=7992) [details] [details] [details]
> > 0.9.6.1 prerelease 35
> > 
> > Here is a quickfix. please test thoroughly.
> > 
> 
> Replyall function appears to ignore multiple CC: and TO: in original quote
> header copy.
> 

REPLY function seems to try to Quote multiple TO and CC addresses.

(From update of attachment 7996 [details])
Reply only should show only one From and the TO addressees (usually one
addressee).  It looks like the same TO addressee is listing multiple times.

(From update of attachment 7997 [details])
It looks like the same addressee is listing multiple times instead of the
different TO addressee.

(In reply to comment #16)
> (In reply to comment #11)
> > (In reply to comment #7)
> > > Created an attachment (id=7992) [details] [details] [details] [details]
> > > 0.9.6.1 prerelease 35
> > > 
> > > Here is a quickfix. please test thoroughly.
> > > 
> > 
> > Replyall function appears to ignore multiple CC: and TO: in original quote
> > header copy.
> > 
> 
> REPLY function seems to try to Quote multiple TO and CC addresses.
> 

Appears to be applying to the to(mail) and from(mail) switch specifically. Let
me check.

Created an attachment (id=7998) [details]
0.9.6.1 prerelease 38

Bugfix for patched version prerelease 35

should be better.

(In reply to comment #20)
> Created an attachment (id=7998) [details] [details]
> 0.9.6.1 prerelease 38
> 
> Bugfix for patched version prerelease 35
> 
> should be better.
> 

It's working a lot better as you indicated.

Do you have any idea why replies to emails routed to shiftmail.com position the
quoted original messages at the top of the reply instead of at the bottom? 
Quoted original messages are set to position at the bottom of a reply.

The headers are in the form of:

Subject:        [smarttemplate4] [Bug 25951] ST4 not working in SeaMonkey 2.32
- Temporal Deadzone
Date:   Mon, 26 Jan 2015 17:27:04 +0000
From:   bugzilla-daemon@mozdev.mozdev.org
<bugzilla-daemon.-.mozdev.mozdev.org.-.subscribe@shiftmail.com>
Reply-To:       bugzilla-daemon.-.mozdev.mozdev.org.-.subscribe@shiftmail.com
To:     leishirsute@yahoo.com


Replies for other emails that are not routed through shiftmail.com appear to be
working correctly now as far as TO and CC addressees and positioning at the
bottom of a reply.

(In reply to comment #21)
> (In reply to comment #20)
> > Created an attachment (id=7998) [details] [details] [details]
> > 0.9.6.1 prerelease 38
> > 
> > Bugfix for patched version prerelease 35
> > 
> > should be better.
> > 
> 
> It's working a lot better as you indicated.

Good. Problems like this were to be expected because I had to eliminate the use
of "var" and had to move some variables in order to "scope" them correctly. The
initalisation of result="" in the loop that iterates the mails was moved
outside of the loop which broke the behavior. Goes to show that generic
variable names like "result" are fairly shitty (original author of the addon),
I renamed it to "addressee" and can now actually read the code better as well.

> 
> Do you have any idea why replies to emails routed to shiftmail.com position the
Yes I have, but let's not spam this bug with other support issues. Just send me
an email for this one :)

Created an attachment (id=8022) [details]
0.9.6.1 prerelease 86

SeaMonkey version bumped up to 2.37.* and various other fixes

Fixed in 1.0.1 Release