I typically read mesages in their own tab. The following behavior is not what I
expect.

Suppose I am reading message x, which is in folder a, in its own tab and I
realize that to better understand it I need to have a look at message y which I
know is in folder b. The natural thing to do for me is to click on the
quickfolder tab for folder b, and look there for message y. If I do so, message
x closes and I see folder a, clicking a second time I get to folder b (as I
wanted).

I think that until a while ago with a single click on the quickfolder tab for
folder b I did move to folder b and still had message x open under its tab, so
that I could easily go back to it after reading whatever I needed from message
y.

I am running QuickFolders 3.12.1 on Thunderbird 24.0 under Windows 7 pro.

(In reply to comment #0)
> I typically read mesages in their own tab. The following behavior is not what I
> expect.
> 
> Suppose I am reading message x, which is in folder a, in its own tab and I
> realize that to better understand it I need to have a look at message y which I
> know is in folder b. The natural thing to do for me is to click on the
> quickfolder tab for folder b, and look there for message y. If I do so, message
> x closes and I see folder a, clicking a second time I get to folder b (as I
> wanted).
> 
> I think that until a while ago with a single click on the quickfolder tab for
> folder b I did move to folder b and still had message x open under its tab, so
> that I could easily go back to it after reading whatever I needed from message
> y.
> 
> I am running QuickFolders 3.12.1 on Thunderbird 24.0 under Windows 7 pro.
> 

What happens if you right-click folder a on the tab bar, then "Open in new
tab"? Or if you don't want folder a in a new tab, you could click the tab for
the 3-pane view, then folder a.

I would expect that (left-)clicking a folder would open it in the current tab,
even if ATM it's a message tab.

What I see is that left-clicking a folder tab when in a message tab goes to the
tab where that folder is open, if there is one; but if there isn't, the 3-pane
tab is duplicated in the current tab (not going to the folder I clicked) but
the tab title on the tab bar doesn't change (it remains the Subject of message
x). … :-?

I'm using:
Mozilla/5.0 (X11; Linux x86_64; rv:27.0) Gecko/20100101 Firefox/27.0
SeaMonkey/2.24a1 ID:20130919003001 c-c:1ea1fc3586db m-c:803189f35921
QF 3.12.2pre9

Oops: in the first paragraph of my reply in comment #1, replace everywhere
"folder a" by "folder b".

P.P.S. Which mailer (Thunderbird or SeaMonkey) are you using, and which version
of the mailer and of QuickFolders? IIUC you're on Windows.

Created an attachment (id=7712) [details]
3.12.2 prerelease 37

This fix modifies the behavior slightly - I am still switching your current
folder on the QuickFolders bar and the current folder toolbar (if visible above
the single messge) to the selected folder. However I do not want to open a new
tab by this action alone. Rather I now stay on the single message, but give you
a chance to pull the message using the envelope of the current message into a
new folder (the folder displayed in the middle of the current folder tab). This
should also work if you select a subfolder from one of the popup menus. I think
switching away from the tab might not be the intended action for most people
reading a single email (and there is the "open in new tab" command for this)
although it might be handy to open a mail tab that already displays the
selected Folder. (so it could be used for switching back to the inbox etc). 

Opening new mail tabs by default seems a little against the conventions of how
the rest of the program works, and so does closing the message (which was
unintended). I hope this is a good compromise.

Created an attachment (id=7713) [details]
3.12.2 prerelease 38

fixing a typo-caused bug in prerelease 37 that completely broke changing folder

*** Bug 25610 has been marked as a duplicate of this bug. ***

Renamed the bug in order to make it clearer what the intention actually is. I
think the expectation of the bug reporters (Becky, Alberto) is that
QuickFolders _should_ in fact do something (navigate to a folder / open /
recycle existing Thunderbird tabs, open a 3pane folder view) when single
clicked. 

While you already can have this behavior by using CTRL+Click (open in new tab)
this is hardly intuitive. I will experiment with some test versions that behave
differently.

New intended behavior:

1. If (while in Single Message view) a QF Tab is clicked that points to a
folder that is already open on one of the other Thunderbird tabs, switch to
that THunderbird tab.

2. If (while in Single Message view) a QF Tab is clicked that isn't open, then
open a new Thunderbird tab with a 3pane view showing the contents of that
folder.


PS: If you claim that QuickFolder did this (or a similar behavior) before, then
this was by accident and not intended behavior. This doesn't make it easier to
implement.

PPS: solution may contain traces of nuts. Bug Assigned.

(In reply to comment #7)

> 
> 1. If (while in Single Message view) a QF Tab is clicked that points to a
> folder that is already open on one of the other Thunderbird tabs, switch to
> that Thunderbird tab.

that part, apparently, works for me already! So if I want to return to a folder
that I have previously viewed in a 3pane tab clicking on its corresponding QF
tab will actually put that Thunderbird tab in the foreground.

Which only leaves:
> 
> 2. If (while in Single Message view) a QF Tab is clicked that isn't open, then
> open a new Thunderbird tab with a 3pane view showing the contents of that
> folder.

to implement: open a new tab if that folder is not already open in another
THunderbird tab.

Created an attachment (id=7719) [details]
3.14 prerelease 4

I attached this to the wrong bug (the one I marked as duplicate)

so here goes:

This kind of / almost does it (opens a new tab if necessary) but it doesn't
alkways switch to "read messages" mode so it might still require an additional
unwanted click. But it is a good step towards the desired behavior.

Please test relentlessly!

The fix that I was sent has worked well for the past 24 hours. I am able to
click on and switch using my top tabs (which are links to my several email
accounts)easily. No more issues with having to double-click to get them to
open, or not being able to switch to a different tab from an email view. Thanks
for the tech support.  I've been using QF for years and wouldn't want to use
Thunderbird without it.

I tried the fix for the last couiple of days and it seems a fair solution to my
original problem.

Thanks a lot,
Alberto

Created an attachment (id=7728) [details]
3.14 prerelease 14

Same as previous, but also works when in a glodaList tab (Search Messages >
Open Email As List), so one can easily open a folder even when looking at
search results.

Created an attachment (id=7730) [details]
3.14 prerelease 16

The previous prerelease had a different GUID (I wanted to avoid pinging AMO's
update server which creates a lot of single entries in my user statistics). The
problem with this was that it leads to 2 versions of QuickFolders being
installed in about:addons.

So I am marking 3.14 prerelease 14 as obsolete. If you have pre 14 installed
(and consequently have 2 QuickFolders showing up in your installed Addons
list), remove pre 14 using about:addons. This will not affect any of the
settings you have stored.

Created an attachment (id=7731) [details]
3.14 prerelease 17

Fixed behavior in SeaMOnkey: in single message view the sinlge message was
simply closed and the tab reused for 3pane voew - the problem is that SeaMOnkey
doesn't seem to have a concept of a separate "single message mode" it always
uses the "3pane" mode and simply hides folder and thread pane:

see also:
http://mxr.mozilla.org/comm-central/source/suite/mailnews/tabmail.js#16

Therefore I added some SM-specific code which checks for the absence of the
folder pane and opens a new tab if there is a single message displayed (with or
without thread pane open) if this is the case. I would consider not leaving the
single message in its own tab as disruptive behavior. 

Now SeaMonkey Messenger window just has to fix the problem of not remembering
the opened tabs and then it would be as useful as Thunderbird. I haven't found
any setting to do this (the browser component has "Restore previous session"
but there is no such thing for the Mail & Newsgroups)

*** Bug 25681 has been marked as a duplicate of this bug. ***

Created an attachment (id=7767) [details]
3.14 beta 1

Adds some folder verification (does the folder file exist). I might add a
hidden setting to disable this in case it fails.

I was experiencing a similar problem to those described by Alberto and Becky;
so I installed the 3.14 beta 1 update, hoping it would solve my problem.

I am now able to click on any of my Quickfolders tabs and have that folder come
up, even if I'm currently reading a message in its own tab.

However, if I'm in a message tab, and click on the Quickfolder tab for say mail
folder x, instead of overwriting the left-hand-most 3-pane mail tab (like
Quickfolders used to do) it now opens up a *new* 3-pane tab for folder x
(unless folder x is already open, in which case Quickfolders just switches to
that tab).

Is there a way to prevent Quickfolders from creating new tabs for my
mailfolders, just because I click on them while in a mail message tab?

I am running Quickfolders 3.14 beta 1 on Thunderbird 24.2.0 on Windows 7 x64
Pro

(In reply to comment #17)
> 
> However, if I'm in a message tab, and click on the Quickfolder tab for say mail
> folder x, instead of overwriting the left-hand-most 3-pane mail tab (like
> Quickfolders used to do) it now opens up a *new* 3-pane tab for folder x
> (unless folder x is already open, in which case Quickfolders just switches to
> that tab).
> 
> Is there a way to prevent Quickfolders from creating new tabs for my
> mailfolders, just because I click on them while in a mail message tab?

Not at the moment - you have to activate the leftmost (Thunderbird) tab if you
want it to change to a different folder. Like you said if you click any other
tab a new folder tab will be opened (or the appropriate folder tab will be
activated if it is already open)

(In reply to comment #0)
> I typically read mesages in their own tab. The following behavior is not what I
> expect.
> 
> Suppose I am reading message x, which is in folder a, in its own tab and I
> realize that to better understand it I need to have a look at message y which I
> know is in folder b. The natural thing to do for me is to click on the
> quickfolder tab for folder b, and look there for message y. If I do so, message
> x closes and I see folder a, clicking a second time I get to folder b (as I
> wanted).
> 
> I think that until a while ago with a single click on the quickfolder tab for
> folder b I did move to folder b and still had message x open under its tab, so
> that I could easily go back to it after reading whatever I needed from message
> y.
> 

Alberto, does the last prerelease work as you expected it?

(In reply to comment #19)
> (In reply to comment #0)
> > I typically read mesages in their own tab. The following behavior is not what I
> > expect.
> > 
> > Suppose I am reading message x, which is in folder a, in its own tab and I
> > realize that to better understand it I need to have a look at message y which I
> > know is in folder b. The natural thing to do for me is to click on the
> > quickfolder tab for folder b, and look there for message y. If I do so, message
> > x closes and I see folder a, clicking a second time I get to folder b (as I
> > wanted).
> > 
> > I think that until a while ago with a single click on the quickfolder tab for
> > folder b I did move to folder b and still had message x open under its tab, so
> > that I could easily go back to it after reading whatever I needed from message
> > y.
> > 
> 
> Alberto, does the last prerelease work as you expected it?
> 

It did not work in the way I expected (which was closer to what 
eringath@gmail.com asks for), but I got used to it and now appreciate the
possibility of having tabs for different folders opened at the same time.
The leftmost tab is still "special" (you cannot close it, nor move another tab
to the left of it), while I think it would be nice if it behaved as all other
tabs.

Best wishes,
Alberto

(In reply to comment #20)
> (In reply to comment #19)
> > 
> > Alberto, does the last prerelease work as you expected it?
> > 
> 
> It did not work in the way I expected (which was closer to what 
> eringath@gmail.com asks for), but I got used to it and now appreciate the
> possibility of having tabs for different folders opened at the same time.
> The leftmost tab is still "special" (you cannot close it, nor move another tab
> to the left of it), while I think it would be nice if it behaved as all other
> tabs.

One of the problems of "nuking" the originating Tab by clicking on any
QuickFolder tab is that we a losing the context of where we came from when we
opened the (presumably important) email in a single tab. So if we are in a very
deeply nested folder structure, e.g. mailbox1>private>friends>special>fred and
then click another QuickFolder tab, we actually loose the place we started
from. This is what I wanted to avoid when I decided to open a new tab (if
folder is not already displayed in a tab). 

Current Algorithm:
Tab is clicked -> the function QuickFolders_MySelectFolder(folderUri) is
executed. The function is 217 lines long, so it is quite complex.
1. check if folderUri exists. If not suggest to fix the tab.
2. store folderUri
3. get tabmail element and check if folder already open, if this is the case
switch to that tab
4. check if the current mode is single message or search result list, if this
is the case
4a if it is not open already (3) open a new tab
4b exit the function
5. Application specific code (SeaMonkey, Thunderbird and Postbox are all
different here) to select the folder in the folder tree. This is actually the
largest portion of the code (123 lines).
6. If folder could not be found in tree exit the function
7. Focus the thread pane
8. speed up code for highlighting the QF tab

I realize that there is people who don't even know that it is possible to open
more than one folder (although this can be very productive, especially when you
work with QF Categories), so if I introduced a (configurable) rule that allows
to ignore whatever is shown in the "targeted" Thunderbird Folder Tab, how
should this work if more than one Folder tab is open? Should it always target
the leftmost (first) folder tab? This might not be what the user desires. Or
should it target the first folder tab to the left of the current tab? 

Although the requirement (don't ever open a new folder tab) sounds simple, it
will actually make it more difficult for me to program, but let's work on some
solid requirements first.

Created an attachment (id=7771) [details]
3.14 prerelease 77

Here is a version that adds a hidden option to never open a new tab. Instead
the very first tab will be switched to the clicked folder. to test this, go to
tools > options. Click Advanced. Select the General Tab. Click [Config
Editor...]

In the search  box enter "quickfolders.behavior".
toggle
extensions.quickfolders.behavior.nonFolderView.openNewTab
to false (by double clicking)