First Last Prev Next    No search results available
Details
: In Stationery template, standard quote header is not removed
Bug#: 25528
: smarttemplate4
: General
Status: RESOLVED
Resolution: LATER
: PC
: Windows NT
: unspecified
: P2
: normal
: ---

:
:
:
:
:
  Show dependency tree - Show dependency graph
People
Reporter: Frederik Niedernolte <f.niedernolte@gmail.com>
Assigned To: Axel Grude <axel.grude@gmail.com>

Attachments
Log file with %quotePlaceholder% instead of the whole sig (22.95 KB, text/plain)
2013-08-07 04:14, Frederik Niedernolte
no flags Details
0.9.4 Prerelease 51 (317.95 KB, application/x-xpinstall)
2013-08-19 03:57, Axel Grude
no flags Details


Note

You need to log in before you can comment on or make changes to this bug.

Related actions


Description:   Opened: 2013-08-07 03:42
When using a Stationery, the standard quote header is displayed before the
quoted mail.

Expected behavior: if the option "remove quote header" is checked, please
remove the standard quote header.
------- Comment #1 From Axel Grude 2013-08-07 04:03:41 -------
Accepted.

However I found this interesting but of code:

case 'reply':
    if (pref.getCom("mail.identity." + idKey + ".auto_quote", true)) {
        newQuote = newQuote && true;
        // we do not delete reply header if stationery has inserted a template!
        // unless: stationery has a placeholder for the original quote text. in
which case we have to do this!
        if (
              pref.isDeleteHeaders(idKey, st4composeType, false)
                  &&
                  (!isStationeryTemplate || (flags &&
flags.hasQuotePlaceholder)) 
                )
        {
            delReplyHeader(idKey);
        }
    }
    break;

which indicated that it already _should_ be removed automatically if you use
the

 %quotePlaceholder%

variable within your Stationery.
------- Comment #2 From Frederik Niedernolte 2013-08-07 04:14:32 -------
Created an attachment (id=7642) [details]
Log file with %quotePlaceholder% instead of the whole sig
------- Comment #3 From Axel Grude 2013-08-07 05:11:09 -------
(In reply to comment #2)
> Created an attachment (id=7642) [details] [details]
> Log file with %quotePlaceholder% instead of the whole sig
> 

Looking at the log file, it looks like you use a html signature file?

Just to be clear: %quotePlaceholder% is not a placeholder for signature, but
for the text of the mail you are replying to (my guess is you know that but
just phrased it a little unclearly).

You are using %sig(2)% within your Stationery file, is this correct? 

I am missing it in the first call to SmartTemplate4.regularize(..).

Maybe you can send me:

1. your stationery file
2. your signature file

off bugzilla 

to make it easier to research / test
------- Comment #4 From Frederik Niedernolte 2013-08-09 05:17:45 -------
"<div class="moz-cite-prefix">schrieb Axel Grude (Axel):<br></div>" isn't
necessary in prerelease 26
------- Comment #5 From Axel Grude 2013-08-19 03:57:26 -------
Created an attachment (id=7655) [details]
0.9.4 Prerelease 51

Better version, which reliably replaces the quote header in Stationery by using
the new %quoteheader% variable.
------- Comment #6 From Frederik Niedernolte 2013-08-19 12:28:18 -------
I cannot see a difference to prerelease 26.
There is still the double entry div class="moz-cite-prefix" and an additional
"&nbsp;" which isn't in the stationary.
Other than that everything works as with build 26.
------- Comment #7 From Axel Grude 2013-08-19 21:36:56 -------
this was apparently caused by the including of body tags within the Stationery. 


The final stationery text is simply:

%sig%<br>
%cursor%<br>
%quouteHeader%<br>
%quotePlaceholder%
------- Comment #8 From Axel Grude 2015-07-09 06:08:46 -------
Can this be marked as fixed?

First Last Prev Next    No search results available