Bugzilla@Mozdev – Bug 25103
0.9.1 inserts unwanted line break int top of <body> in html mode
Last modified: 2012-09-21 04:33:59
You need to log in before you can comment on or make changes to this bug.
This is what the email body of 0.9pre257 looked: <body bgcolor="#ffffff" text="#000000"> <div id="IDstID"><tt>Hi Markus,<br> 0.9.1 changed this to: <body bgcolor="#ffffff" text="#000000"> <br> <div id="smartTemplate4-template"><tt>Hi Markus,<br> Please remove the additional line break after the body tag. If I'd want a line break here, I'd add it to my template.
I have a similar but different issue. My assumption is that the line-break is automatically inserted as a place for your reply/forward to begin being typed; while keeping your reply/forward outside of the smartTemplate4-template DIV. My issue is I would like to have two line-breaks outside of the smarttemplate4-template DIV. This gives more room for my reply. I find myself always having to add the additional space every email. Also, this is consistent with the amount of space MS Outlook automatically creates, (granted we should not use MS products as a baseline for comparison!) However, this obviously depends on how the user is using ST4 whether or not (s)he wants 0, 1, 2,..10 line breaks inserted automatically.
I totally agree with the issue poster; The added <br> should be removed because I now have to go back to an older version of smarttemplate, for all the employees of my company... which is a real load of work. I don't mind if it would be optional, like Marc Main suggests, as long as I can configurate it so that there is no <br>.
There is some code in 0.9.1 that inserts ONE <br> as first element in the <body> tag. However, if you use the Template, you would probably want to start editing _after_ it, like so:L Dear %to(firstname)%, (Cursor Position) I added a global setting for inserting the <br> which will be false by default, but maybe I should change it to an integer (and default to 0). This way users could configure 0, 1 or more new lines at the top of their emails? Hope I understand you correctly.
Created an attachment (id=7349) [details] configurable version this version has a hidden about:config setting: extensions.smartTemplate4.insertBRatTop which is a flag to configure whether to insert the <br>. default is false. Also note that we have decided to split the template (where you put salutation and other elements of your email template) and the quote header (the part that introduces the original email, such as "on 12/04/2012, Axel wrote:", into 2 separate text fields in order to better support "reply at bottom". Eventually we will have a page with global settings, but that needs to be built first.
(In reply to comment #3) >... maybe I should change it to an integer (and default to 0). This > way users could configure 0, 1 or more new lines at the top of their emails? I think this is a good solution. In the past we have just not automatically added any lines, requiring the user to create line breaks in their template. This gives the user full control, but also guarantees the full reply message would be within the ST4 created DIV which is not desirable IMO.
(In reply to comment #4) Thanks very much! I tested the new version; the first additional <br> is now gone! When will this be in a normal release?
(In reply to comment #6) > (In reply to comment #4) > Thanks very much! I tested the new version; the first additional <br> is now > gone! > > When will this be in a normal release? > As soon as 0.9.2 will be released. Could be a couple of weeks, as we need the translators to work on the new options dialogs. And we need a hell of a lot of testing to do. Since I don't do this full time, and I am not paid, I can only put in so many hours per day. Axel
Version 0.9.2pre24 FIXED the problem. Thanks a bunch, Axel.
(In reply to comment #7) > (In reply to comment #6) > > (In reply to comment #4) > > Thanks very much! I tested the new version; the first additional <br> is now > > gone! > > > > When will this be in a normal release? > > > > As soon as 0.9.2 will be released. Could be a couple of weeks, as we need the > translators to work on the new options dialogs. > > And we need a hell of a lot of testing to do. Since I don't do this full time, > and I am not paid, I can only put in so many hours per day. > > Axel > Hi Axel, While testing the new (not yet released version of SmartTemplate4 (0.9.2pre24) I found out that when I fill in the second text-field and checking the checkbox in between the two text-fields I get one signature when I reply, but two signatures when I forward. I have both settings exactly the same. So I think there is something not quite right there. Bets regards, Johan
Created an attachment (id=7375) [details] 0.9.2 pre 51 Here is a tidied up version. This really removes all <br> at the top, provided the setting is set to false.
(In reply to comment #10) 0.9.2pre51 works for me. No line break at the top. It even fixes a bug of 0.9.2pre24 I just found this morning. When you replied to a message, saved it, closed it, then reopened it, an additional line break was inserted at the top. Sometimes even a second SmartTemplate div was added at the top of the message. But anyway, this one seems to be fixed now, too. Thanks a lot, Axel.
(In reply to comment #11) > (In reply to comment #10) > > 0.9.2pre51 works for me. No line break at the top. > > It even fixes a bug of 0.9.2pre24 I just found this morning. That seems logical :) There is only one developer (me) and obviously all fixes are cumulative. > When you replied > to a message, saved it, closed it, then reopened it, an additional line break > was inserted at the top. Sometimes even a second SmartTemplate div was added at > the top of the message. But anyway, this one seems to be fixed now, too. > > Thanks a lot, Axel. Good. now time for the translators to do their bit.
I've installed the pre 51 and it fixes the problems I encountered. However, when I try to change some settings I get the following error in the smart template screen: XML-parsefout: ongedefinieerde entiteit Locatie: chrome://smarttemplate4/content/settings.xul Regelnummer 180, kolom 12: <label value = "&pref_templateBox.label;"/> ----------------------------------------------------------------------------------------^ Maybe this has something to do with my language settings (dutch)
*** Bug 25145 has been marked as a duplicate of this bug. ***