First Last Prev Next    No search results available
Details
: Support bottom reply with headers on top
Bug#: 25099
: smarttemplate4
: General
Status: RESOLVED
Resolution: FIXED
: PC
: Windows XP
: unspecified
: P3
: enhancement
: ---

:
:
:
:
:
  Show dependency tree - Show dependency graph
People
Reporter: Axel Grude <axel.grude@gmail.com>
Assigned To: Axel Grude <axel.grude@gmail.com>
:

Attachments
Proposal for new settings (39.25 KB, image/png)
2012-08-21 17:12, Axel Grude
no flags Details
Preview 24 (246.72 KB, application/x-xpinstall)
2012-08-23 06:09, Axel Grude
no flags Details
0.9.2 pre 40 (247.53 KB, application/x-xpinstall)
2012-08-24 15:24, Axel Grude
no flags Details


Note

You need to log in before you can comment on or make changes to this bug.

Related actions


Description:   Opened: 2012-08-21 17:05
When "start my reply below the quote" is selected, then the complete template
is being placed below the quoted email. For this case, we need to be able to
have the mail template below, while moving the header fields "on 01/01/2010 Mr
x wrote: ..." to the top before the quoted email.
------- Comment #1 From Axel Grude 2012-08-21 17:08:33 -------
(In reply to comment #0)
> When "start my reply below the quote" is selected, then the complete template
> is being placed below the quoted email. For this case, we need to be able to
> have the mail template below, while moving the header fields "on 01/01/2010 Mr
> x wrote: ..." to the top before the quoted email.
> 

St4 was originally designed only to hold the "quote header fields" and as such
was hard coded to put _everything_ on top of the quoted email. However, we now
try to honor the setting "start reply below" which has this bad side effect.

The only efficient way to solve this would be by splitting the settings so that
st4 knows which part to put before the email and which part below, should the
said option be enabled.
------- Comment #2 From Axel Grude 2012-08-21 17:12:28 -------
Created an attachment (id=7347) [details]
Proposal for new settings

Proposal for a possible way of managing these settings separately. the old
template could be imported into the top box (Template Reply) without any side
effects, the user could then enhance her templates by moving the "quote header"
part into the lower textbox (Quote Header).

(Quote Header) would always be displayed on top of the quoted email, 
(Template Reply) would honor the settings in Composition & Addressing
------- Comment #3 From Axel Grude 2012-08-23 06:09:53 -------
Created an attachment (id=7351) [details]
Preview 24

here is a preview version that does it in the way suggested.quote header and
template will be kept separate fro this point onward.
------- Comment #4 From Ingo Karkat 2012-08-24 13:02:27 -------
Thanks Axel! This indeed fixes the issue.

One minor problem: I get an unwanted empty line before the inserted quote
header (i.e. line number 1 of the mail) when replying. In the SmartTemplate4
config, my Quote Header is
On %X:=sent%%dateshort% %date_tz%, %fromname% wrote:

with "Use instead of default header quote" selected. In the Thunderbird config,
mail.identity.id1.reply_on_top = 0
Thunderbird 14.0 on Windows Vista/x86.
------- Comment #5 From Axel Grude 2012-08-24 13:22:26 -------
(In reply to comment #4)
> Thanks Axel! This indeed fixes the issue.
> 
> One minor problem: I get an unwanted empty line before the inserted quote
> header (i.e. line number 1 of the mail) when replying. In the SmartTemplate4
> config, my Quote Header is
> On %X:=sent%%dateshort% %date_tz%, %fromname% wrote:
> 
> with "Use instead of default header quote" selected. In the Thunderbird config,
> mail.identity.id1.reply_on_top = 0
> Thunderbird 14.0 on Windows Vista/x86.

Yes, we know about this problem, there is a fix (through a global setting) in
the works for this. I will post another update to this patch soon. 
------- Comment #6 From Axel Grude 2012-08-24 15:24:22 -------
Created an attachment (id=7355) [details]
0.9.2 pre 40

An updated, more stable version. 

To do: copying of fields from help panel to the top textbox, at the moment
everything is always pasted into the bottom text box, even though the focus
indicator points otherwise.

First Last Prev Next    No search results available