Bugzilla@Mozdev – Bug 26051
Remove rotating icons for pro users
Last modified: 2015-10-31 03:46:59
You need to log in before you can comment on or make changes to this bug.
Remove rotating icons for registered pro users
Accepted. The other question would be whether it might be helpful to eventually reword some of the UI for registered users [which will be treated out of scope for this bug, just documenting them here] A) QuickFolders Pro License ... => Renew License (should happen as soon as license is expired) B) QuickFolders Pro License Window: Add a notice at the top "Your License is valid Until..." - I haven't thought about a way of renewing a license so that it the term will start exactly when the existing one expires (this is slightly tricky as it would require the original license to be transmitted to the web shop); obviously it should be possible to renew before the expiration date. C) Rename the button "Buy License" to "Renew License" if existing license key was valid and is expired
One thing that is slightly problematic for removing the icons: 1) the decryption of the license key takes time so I do not automatically check for the license key when Thunderbird starts, but I do it "on demand" when a premium feature is used 2) I would have to change this and run the validation on startup which will slow down Thunderbird performance for premium users (startup) so although it sounds like a simple request, the implementation will be slightly more complicated...
Created an attachment (id=8071) [details] 4.1.1 prerelease 38 Here is a prerelease that _automatically_ removes the animations on the options menu and also on the QF Pro tab in options dialog (which delayed this upload by another 3 hours; debugging style sheet changes in memory is notoriously time-consuming) at startup. There is however one *major* caveat: Since the JavaScript for decoding of the license key is carried out on the main thread (and not in the background, as JavaScript is not multi-threaded) there is a definite speed penalty. I am trying to defer this with a hard coded timeout - in this version 1 second after QuickFolder's initializing function has completed. Note that the "gap" of 1555ms is in part caused by that waiting period (and not just loading bookmarks in my system), and there might be other activities before the system says "Creating RSA key..." - on my quad core there is about 28ms used up so I guess here it is acceptable. YMMV... QuickFolders 18:20:54.707 [4 ms] bookmarks.load... ---------- QuickFolders 18:20:56.262 [1555 ms] Creating RSA key + decrypting ---------- QuickFolders 18:20:56.290 [28 ms] Decryption Complete : decrypted string = QF-xxx.xxxx@gmail.com:2016-07-12 ---------- QuickFolders 18:20:56.291 [1 ms] validateLicense() - successful. ---------- QuickFolders 18:20:56.291 [0 ms] validateLicense() returns Valid [1] ---------- QuickFolders 18:20:56.291 [0 ms] Premium License found - removing Animations()...
Created an attachment (id=8072) [details] 4.1.1 prerelease 53 Added some style fixes and a smaller green icon for Pro users.
Created an attachment (id=8073) [details] 4.1.1 prerelease 54 Removed test menu item ("Remove animations") Version was also tested in Postbox / SeaMonkey.
Released in version 4.1.1, 17/07/2015