First Last Prev Next    No search results available
Details
: Cloning Filters fails with Non-String condition attributes
Bug#: 25686
: quickFilters
: General
Status: RESOLVED
Resolution: FIXED
: PC
: Windows NT
: unspecified
: P1
: normal
: ---
:
:
:
:
:
  Show dependency tree - Show dependency graph
People
Reporter: Axel Grude <axel.grude@gmail.com>
Assigned To: Axel Grude <axel.grude@gmail.com>

Attachments
2.3.1 prerelease 40 (182.45 KB, application/x-xpinstall)
2014-01-30 20:19, Axel Grude 		no flags Details
2.3.1 prerelease 61 (183.62 KB, application/x-xpinstall)
2014-02-02 09:58, Axel Grude 		no flags Details
Hide Obsolete (1) Add an attachment (proposed patch, testcase, etc.)


Note

You need to log in before you can comment on or make changes to this bug.

Related actions

Description:   Opened: 2014-01-30 17:52 
If I try to clone or merge a filter that has a condition that isn't a string
(e.g. Read Status) the merge fails. 

Instead there is the following error in error console:

Error: NS_ERROR_ILLEGAL_VALUE: Component returned failure code: 0x80070057
(NS_ERROR_ILLEGAL_VALUE) [nsIMsgSearchValue.str]
Quelldatei: chrome://quickfilters/content/qFilters-utils.js
Zeile: 671
------- Comment #1 From Axel Grude 2014-01-30 17:53:38 ------- 
The error is caused by always copying the nsMsgSearchValue.str property.
Apparently even merely reading this property will throw an error if the
attribute is not a string attribute:

https://mxr.mozilla.org/comm-central/source/mailnews/base/search/src/nsMsgSearchValue.cpp#59
------- Comment #2 From Axel Grude 2014-01-30 20:19:27 ------- 
Created an attachment (id=7772) [details]
2.3.1 prerelease 40

This should fix cloning and merging for cases with esoteric filter conditions
such as Status, junk Status, age, Date etc.

tested in Thunderbird 27 and Postbox 3.0.8

Still needs testing in SeaMonkey
------- Comment #3 From Axel Grude 2014-02-02 09:58:53 ------- 
Created an attachment (id=7775) [details]
2.3.1 prerelease 61
------- Comment #4 From Axel Grude 2016-01-09 09:21:16 ------- 
Fixed in Version 2.4, Released February 24, 2014
First Last Prev Next    No search results available