First Last Prev Next    No search results available
Details
: New filters do not automatically run when getting mail
Bug#: 26625
: quickFilters
: General
Status: RESOLVED
Resolution: FIXED
: PC
: Windows NT
: unspecified
: P2
: major
: ---

:
:
:
:
:
  Show dependency tree - Show dependency graph
People
Reporter: Axel Grude <axel.grude@gmail.com>
Assigned To: Axel Grude <axel.grude@gmail.com>

Attachments
3.7.1 prerelease 15 (393.23 KB, application/x-xpinstall)
2018-12-27 13:38, Axel Grude
no flags Details
3.7.1 prerelease 41 (413.32 KB, application/x-xpinstall)
2018-12-30 12:14, Axel Grude
no flags Details
3.7.1 prerelease 42 (413.32 KB, application/x-xpinstall)
2018-12-30 12:48, Axel Grude
no flags Details
3.7.1 prerelease 54 (418.64 KB, application/x-xpinstall)
2018-12-31 04:01, Axel Grude
no flags Details


Note

You need to log in before you can comment on or make changes to this bug.

Related actions


Description:   Opened: 2018-12-27 09:51
Newly created filters do not run automatically only when running manually.
------- Comment #1 From Axel Grude 2018-12-27 10:09:03 -------
When the filter type default settings were introduced in New Filter Properties:

(Getting new mail, after junk classification, when archiving, after sending)

the "getting new mail" flag was falsely linked to inverted "Run Manual" - both
are 2 separate options.

The "incoming" flag is composited from InboxRule + NewsRule (bit1 and bit3) -
if neither of these bits is set the rule will not be executed automatically. A
typical flagset would be 224 (0x11100000) - typically a mail (not newsgroup)
filter would have bit1 set sp wuld result in an odd decimal value.

https://dxr.mozilla.org/comm-central/source/comm/mailnews/base/search/public/nsMsgFilterCore.idl#11


  const long None             = 0x00;
  const long InboxRule        = 0x01;
  const long InboxJavaScript  = 0x02;
  const long Inbox            = InboxRule | InboxJavaScript;
  const long NewsRule         = 0x04;
  const long NewsJavaScript   = 0x08;
  const long News             = NewsRule | NewsJavaScript;
  const long Incoming         = Inbox | News;
  const long Manual           = 0x10;
  const long PostPlugin       = 0x20; // After bayes filtering
  const long PostOutgoing     = 0x40; // After sending
  const long Archive          = 0x80; // Before archiving
  const long All              = Incoming | Manual;
------- Comment #2 From Axel Grude 2018-12-27 13:38:09 -------
Created an attachment (id=8569) [details]
3.7.1 prerelease 15

Added a merge feature when importing filters - if a matching filter (same name)
is found it replaces the original. 

this does NOT check for modifications (and cannot check the date) so it won't
prevent a NEWER filter to be overwritten by an older version of it. 

To fix the  "broken" filters, first export everything - then using a JSON
editor (such as notepad++) delete all filters that have an "odd" filtertype,
e./g/. 

   "filterType": 17,

. If you are deleting the last element, make sure the array (and file) ends
without a comma, like this:
        }
      ]
    }
  ]
}



keep all filters with an even value such as 
      "filterType": 224,

... replace the even numbers with 17 (for instance) and save. reimport the
file. A popup will briefly show how many filters were successfully replaced.

17 = runs on import (before Junk classification) & when running Manually
------- Comment #3 From Axel Grude 2018-12-30 12:14:35 -------
Created an attachment (id=8572) [details]
3.7.1 prerelease 41

Added a button for fixing the problematic filters.
------- Comment #4 From Axel Grude 2018-12-30 12:48:39 -------
Created an attachment (id=8573) [details]
3.7.1 prerelease 42

Updated internal default version number to show correct change log.
------- Comment #5 From Axel Grude 2018-12-31 04:01:55 -------
Created an attachment (id=8574) [details]
3.7.1 prerelease 54

Added fix for filters in local folders (it turns out they also have the
InboxRule flag set by default) and notifications on results.
------- Comment #6 From Axel Grude 2019-01-04 02:33:06 -------
Fixeed in release 3.8 on 1/1/2019

First Last Prev Next    No search results available