First Last Prev Next    No search results available
Details
: Shift-[Key] shortcuts interferes with Tb Conversations Addon
Bug#: 26202
: QuickFolders
: General
Status: RESOLVED
Resolution: FIXED
: PC
: Windows XP
: unspecified
: P2
: enhancement
: ---

:
:
:
:
:
  Show dependency tree - Show dependency graph
People
Reporter: Garfae <garfae@gmail.com>
Assigned To: Axel Grude <axel.grude@gmail.com>
:

Attachments
QF 4.4.3 prerelease 10 (692.66 KB, application/x-xpinstall)
2016-04-22 04:56, Axel Grude
no flags Details


Note

You need to log in before you can comment on or make changes to this bug.

Related actions


Description:   Opened: 2016-04-21 17:52
Since Shift-[Key] combinations interefere with other add-ons (specifically
Thunderbird Conversations in our case), we would like to be able to assign an
additional modifier (e.g. Shift-Alt) instead of plain Shift.
------- Comment #1 From Axel Grude 2016-04-22 01:14:33 -------
(In reply to comment #0)
> Since Shift-[Key] combinations interefere with other add-ons (specifically
> Thunderbird Conversations in our case), we would like to be able to assign an
> additional modifier (e.g. Shift-Alt) instead of plain Shift.
> 

For which shortcuts specifically? What are the other ADdons doing.

Please be as specific as possible.
------- Comment #2 From Garfae 2016-04-22 01:34:13 -------
Any Shift-Letter or Shift-Number combinations (in this case, Shift-J and
Shift-M, used to quick jump/move).

They interfere with the Thunderbird Conversations add-on because the add-on
allows to reply to messages inline (i.e. within the message pane), so it's
impossible to write e.g. an uppercase 'M' letter since it gets caught
(appropriately) by QuickFolders.
------- Comment #3 From Axel Grude 2016-04-22 04:01:28 -------
(In reply to comment #2)
> Any Shift-Letter or Shift-Number combinations (in this case, Shift-J and
> Shift-M, used to quick jump/move).
> 
> They interfere with the Thunderbird Conversations add-on because the add-on
> allows to reply to messages inline (i.e. within the message pane), so it's
> impossible to write e.g. an uppercase 'M' letter since it gets caught
> (appropriately) by QuickFolders.
> 

It might be better if I restrict the SHIFT-M / J (I thought I already did) not
to be active while you are editing in the conversation Addon. I understand it
is happening in their editor?
------- Comment #4 From Garfae 2016-04-22 04:22:34 -------
Yes, that should cut it too! It is indeeed happening in their in-conversation
editor. (And when replying using "in a new window" option, everything is fine
obviously.)
------- Comment #5 From Axel Grude 2016-04-22 04:56:38 -------
Created an attachment (id=8172) [details]
QF 4.4.3 prerelease 10

In this patch, I check for the baseURI of the event target to make sure it is
not the email within the conversations Addon. From what I have tested it will
avoid the quickMove / quickJump shortcuts while editing in conversation mode.

These keyboard events (SHIFT+M, SHIFT+J, SHIFT+configurable key) are IGNORED if
the event:

 (does not target threadTree, folderTree or accountTree)
 AND
 (
  (
   (event happens in a textarea or textbox) 
    AND
   (event is not in a <BODY> tag)
  )
  OR
   eventTarget.baseURI starts with "chrome://conversations"
 )

last bit added for the purpose of fixing this bug. From my tests, the shortcut
will still work in a conversation _as long as you are not in the editing area_
------- Comment #6 From Axel Grude 2016-07-25 10:02:59 -------
Release 4.5 - Resolved Fixed

First Last Prev Next    No search results available