As a feature I would like to be able to turn off the toolbar. As a bug the
close button on the toolbar does not function and the toolbar rests at top
right of messages and forces message to occupy only the left half of the
window.

Could you post a screen shot? It is not clear whether you mean the main
QuickFolders bar (which can be hidden by using View / Toolbars / QuickFolders
toolbar) and which has no close button - like all other toolbars. Or do you
mean the Current Folder toolbar, which has a close button at the right? A
screenshot with close button highlighted would be helpful. Also, which version
of QuickFolders and which version of Thunderbird are we talking about?

Mozilla/5.0 (X11; Linux x86_64; rv:13.0a1) Gecko/20120216 Firefox/13.0a1
SeaMonkey/2.10a1 ID:20120216003016

QuickFolders 2.13

Works for me.

Created an attachment (id=7175) [details]
Screenshot

(In reply to comment #3)
> Created an attachment (id=7175) [details] [details]
> Screenshot
> 

Is that theme Noia 2.0 extreme? I just tested all 3pane views with that:

View > Layout > Classic View
View > Layout > Wide View
View > Layout > Vertical View

but I could not get it to display in the way that it shows on your screen shot. 

Further, in when opened in a tab in single message view the toolbar shows above
the single message.

When I open a message in a new window, the toolbar is not displayed at all.

Unfortunately the screenshot does not tell me what mode you are using, and why
thunderbird 10 has no tabs?

Have you got any other extensions installed that potentially interfere with the
3pane overlay? Can you try to open DOM-inspector and inspect the window in
chrome mode to find out the document name?

Also, can you check tools > error console, to whether any warnings or errors
are shown after opening the single message? QF seems to behave as if you are
running an older version of Thunderbird (pre10) where the stacking of the
header structure was different; maybe something bad is happening during the
version recognition. Also try to enable Debug mode for more information.

You can record debugging to text by installing console2 - highly recommended
over the normal error console. Then highlight the contents of the Error Console
and copy to clipboard via right-click.

(In reply to comment #5)
> Also, can you check tools > error console, to whether any warnings or errors
> are shown after opening the single message? QF seems to behave as if you are
> running an older version of Thunderbird (pre10) where the stacking of the
> header structure was different; maybe something bad is happening during the
> version recognition. Also try to enable Debug mode for more information.
> 
> You can record debugging to text by installing console2 - highly recommended
> over the normal error console. Then highlight the contents of the Error Console
> and copy to clipboard via right-click.
> 

YOu need to give the complete list of extensions and which theme is active in
order to complete bug investigation. Also please check the error output in
tools / error console.

thanks
  Axel

(In reply to comment #6)
> (In reply to comment #5)
> > Also, can you check tools > error console, to whether any warnings or errors
> > are shown after opening the single message? QF seems to behave as if you are
> > running an older version of Thunderbird (pre10) where the stacking of the
> > header structure was different; maybe something bad is happening during the
> > version recognition. Also try to enable Debug mode for more information.
> > 
> > You can record debugging to text by installing console2 - highly recommended
> > over the normal error console. Then highlight the contents of the Error Console
> > and copy to clipboard via right-click.
> > 
> 
> YOu need to give the complete list of extensions and which theme is active in
> order to complete bug investigation. Also please check the error output in
> tools / error console.
> 
> thanks
>   Axel
> 

I'll go through all of that as soon as I have a little time (day or 2).In the
meantime, you might want to know that this issue only came up whenI applied the
most recent update to Tbird and then the most recent quickfolders update, this
issue appeared. I made no changes to other addons.


Where do I find console2

For Starters the Error console shows one warning upon opening a single message:

Warning: XUL box for toolbarbutton element contained an inline #text child,
forcing all its children to be wrapped in a block.
Source File: chrome://messenger/content/messageWindow.xul
Line: 0 

Here is content of messageWindow.xul:

<?xml version="1.0"?>


<?xml-stylesheet href="chrome://messenger/skin/messageWindow.css"
type="text/css"?>

<?xul-overlay href="chrome://communicator/content/utilityOverlay.xul"?>
<?xul-overlay href="chrome://messenger/content/msgHdrViewOverlay.xul"?>
<?xul-overlay href="chrome://messenger/content/mailWindowOverlay.xul"?>
<?xul-overlay href="chrome://messenger/content/mailOverlay.xul"?>
<?xul-overlay href="chrome://messenger/content/editContactOverlay.xul"?>

<!DOCTYPE window [
<!ENTITY % brandDTD SYSTEM "chrome://branding/locale/brand.dtd" >
%brandDTD;
<!ENTITY % messengerDTD SYSTEM "chrome://messenger/locale/messenger.dtd" >
%messengerDTD;
<!ENTITY % customizeToolbarDTD SYSTEM
"chrome://global/locale/customizeToolbar.dtd">
%customizeToolbarDTD;
]>

<!--
  - This window displays a single message.
  -->
<window id="messengerWindow"
        xmlns="http://www.mozilla.org/keymaster/gatekeeper/there.is.only.xul"
        title="&titledefault.label;"
        titlemodifier="&titledefault.label;"
        titlemenuseparator="&titleSeparator.label;"
        onload="OnLoadMessageWindow()"
        onunload="OnUnloadMessageWindow()"
        persist="width height screenX screenY sizemode"
        toggletoolbar="true"
        windowtype="mail:messageWindow"
        lightweightthemes="true"
        lightweightthemesfooter="status-bar">

  <stringbundleset id="stringbundleset">
    <stringbundle id="bundle_brand"
src="chrome://branding/locale/brand.properties"/>
    <stringbundle id="bundle_offlinePrompts"
src="chrome://messenger/locale/offline.properties"/>
  </stringbundleset>

  <script type="application/javascript"
src="chrome://global/content/globalOverlay.js"/>
  <script type="application/javascript"
src="chrome://messenger/content/shareglue.js"/>
  <script type="application/javascript"
src="chrome://messenger/content/commandglue.js"/>

  <script type="application/javascript"
src="chrome://messenger/content/folderDisplay.js"/>
  <script type="application/javascript"
src="chrome://messenger/content/messageDisplay.js"/>
  <script type="application/javascript"
src="chrome://messenger/content/mailWindow.js"/>
  <script type="application/javascript"
src="chrome://messenger/content/messageWindow.js"/>
  <script type="application/javascript"
src="chrome://messenger/content/accountUtils.js"/>
  <script type="application/javascript"
src="chrome://global/content/contentAreaUtils.js"/>
  <script type="application/javascript"
src="chrome://messenger/content/nsContextMenu.js"/>
  <script type="application/javascript"
src="chrome://messenger/content/mailContextMenus.js"/>
  <script type="application/javascript"
src="chrome://messenger/content/phishingDetector.js"/>

  <script type="application/javascript"
src="chrome://communicator/content/contentAreaClick.js"/>
  <script type="application/javascript"
src="chrome://global/content/nsDragAndDrop.js"/>
  <script type="application/javascript"
src="chrome://messenger/content/msgViewNavigation.js"/>
  <script type="application/javascript"
src="chrome://messenger/content/widgetglue.js"/>
  <script type="application/javascript"
src="chrome://messenger/content/editContactOverlay.js"/>

  <commandset id="mailCommands">
    <commandset id="mailFileMenuItems"/>
    <commandset id="mailViewMenuItems"/>

    <commandset id="mailEditMenuItems"/>
    <commandset id="mailSearchMenuItems"/>
    <commandset id="mailGoMenuItems"/>
    <commandset id="mailMessageMenuItems"/>
    <commandset id="mailToolbarItems"/>
    <commandset id="mailGetMsgMenuItems"/>
    <commandset id="mailMarkMenuItems"/>
    <commandset id="mailToolsMenuItems"/>
    <commandset id="mailEditContextMenuItems"/>

    <commandset id="tasksCommands"/>
    <commandset id="commandKeys"/>
    <command id="cmd_close" oncommand="window.close();"/>
  </commandset>

  <keyset id="mailKeys">
    <keyset id="tasksKeys"/>
    <key keycode="VK_ESCAPE" oncommand="window.close();"/>
  </keyset>

  <popupset>
    <panel id="editContactPanel"/>
    <menupopup id="emailAddressPopup" class="emailAddressPopup"
position="after_start"
              
onpopupshowing="setupEmailAddressPopup(findEmailNodeFromPopupNode(document.popupNode,
'emailAddressPopup')); goUpdateCommand('cmd_createFilterFromPopup')"
              
onpopuphiding="hideEmailNewsPopup(findEmailNodeFromPopupNode(document.popupNode,
'emailAddressPopup'))">
      <menuitem id="emailAddressPlaceHolder" label=""
                disabled="true"/>
      <menuseparator/>
      <menuitem id="addToAddressBookItem"
                label="&AddDirectlyToAddressBook.label;"
                accesskey="&AddDirectlyToAddressBook.accesskey;"
               
oncommand="AddContact(findEmailNodeFromPopupNode(document.popupNode,
'emailAddressPopup'))"/>
      <menuitem id="editContactItem" label="&EditContact.label;" hidden="true"
                accesskey="&EditContact.accesskey;"
               
oncommand="EditContact(findEmailNodeFromPopupNode(document.popupNode,
'emailAddressPopup'))"/>
      <menuitem id="viewContactItem" label="&ViewContact.label;" hidden="true"
                accesskey="&ViewContact.accesskey;"
               
oncommand="EditContact(findEmailNodeFromPopupNode(document.popupNode,
'emailAddressPopup'))"/>

      <menuitem id="sendMailToItem" label="&SendMessageTo.label;"
                accesskey="&SendMessageTo.accesskey;"
               
oncommand="SendMailToNode(findEmailNodeFromPopupNode(document.popupNode,
'emailAddressPopup'))"/>
      <menuitem id="copyEmailAddressItem" label="&CopyEmailAddress.label;"
                accesskey="&CopyEmailAddress.accesskey;"
               
oncommand="CopyEmailNewsAddress(findEmailNodeFromPopupNode(document.popupNode,
'emailAddressPopup'))"/>
      <menuseparator/>
      <menuitem id="createFilterFromItem" label="&CreateFilterFrom.label;"
                accesskey="&CreateFilterFrom.accesskey;"
               
oncommand="CreateFilter(findEmailNodeFromPopupNode(document.popupNode,
'emailAddressPopup'))"
                observes="cmd_createFilterFromPopup"/>
    </menupopup>

    <menupopup id="messageIdContext"/>

    <menupopup id="mailContext"/>
  </popupset>

  <menupopup id="attachmentListContext"/>
  <menupopup id="attachmentItemContext"/>
  <menupopup id="header-toolbar-context-menu"/>
  <menupopup id="attachment-toolbar-context-menu"/>
  <menupopup id="copyUrlPopup"/>
  <menupopup id="toolbar-context-menu"/>

  <toolbox id="mail-toolbox" class="toolbox-top">
  </toolbox>

  <tooltip id="aHTMLTooltip" onpopupshowing="return
FillInHTMLTooltip(document.tooltipNode);"/>

 <!-- msg header view -->
  <!-- a convenience box for ease of extension overlaying -->
  <hbox id="messagepaneboxwrapper" flex="1">
    <vbox id="messagepanebox" flex="3"
          ondragover="nsDragAndDrop.dragOver(event, messagepaneObserver);"
          ondragdrop="nsDragAndDrop.drop(event, messagepaneObserver);"
          ondragexit="nsDragAndDrop.dragExit(event, messagepaneObserver);">

      <hbox id="msgHeaderView"/>
      <hbox id="editMessageBox"/>

      <deck id="msgNotificationBar"/>

      <!-- message view -->
      <browser id="messagepane" context="mailContext" tooltip="aHTMLTooltip"
               style="height: 0px; min-height: 1px" flex="1" name="messagepane"
               disablesecurity="true" disablehistory="true"
type="content-primary"
               onresize="return messagePaneOnResize(event);" autofind="false"
               src="about:blank" onclick="return contentAreaClick(event);" />
      <splitter id="attachment-splitter" collapse="after"
resizebefore="closest" resizeafter="closest" collapsed="true"/>
      <vbox id="attachmentView"/>
      <findbar id="FindToolbar" browserid="messagepane"/>
    </vbox>
  </hbox>

  <panel id="customizeToolbarSheetPopup" noautohide="true">
    <iframe id="customizeToolbarSheetIFrame"
            style="&dialog.style;"
            hidden="true"/>
  </panel>

  <statusbar class="chromeclass-status" id="status-bar"/>
</window>

Current active addons:

Lightning 1.2.1
Noia 2.0 eXtreme XT 3.36
Quickfolders 2.12
Quicktext 0.9.11.1
Test Pilot for Thunderbird 1.3.5
xSidebar for Thunderbird 0.8

That is all active addons

(In reply to comment #8)
> For Starters the Error console shows one warning upon opening a single message:
> 
> Warning: XUL box for toolbarbutton element contained an inline #text child,
> forcing all its children to be wrapped in a block.

Ok this should definitely not be happening. I am overlaying

<vbox id="messagepanebox">
and inject my current folder toolbar before the browser element "messagepane"


here is the relevant part of the messageWindow:

>  <!-- msg header view -->
>   <!-- a convenience box for ease of extension overlaying -->
>   <hbox id="messagepaneboxwrapper" flex="1">
>     <vbox id="messagepanebox" flex="3">
> 
>       <hbox id="msgHeaderView"/>
>       <hbox id="editMessageBox"/>
> 
>       <deck id="msgNotificationBar"/>
> 
>       <!-- message view -->
>       <browser id="messagepane" name="messagepane" />

the rest isn't relevant.

My toolbar is in a special hbox:

<vbox id="messagepanebox">
  <hbox id="QuickFolders-PreviewToolbarPanel-Single"
insertbefore="messagepane">
     <spacer flex="5" id="QF-CurrentLeftSpacer"/>
        <toolbar id="QuickFolders-CurrentFolderTools">
           <toolbarbutton ../>
           <toolbarbutton ../>
           <toolbarbutton ../>
        </toolbar>
     </spacer>
  </hbox>
</vbox>

that is all there is to it; there are no inline text elements it is just
spacer, toolbar, spacer. 

This leads me to believe that another extension is injecting some text into
this area, which makes my current Folder toolbar stick out.

What other extensions have you installed? What's your current theme?

It is possible that other extension authors were not as careful as me when
overlaying their xul. I have 3 different sets of xul files, one for Tb2, one
for Tb3-9, and one for Tb10+...

You can find out whether there are any text elements in the toolbarbuttons.
Best use DOM inspector and remove the buttons, one by one.

DOMi will give you the real resulting window (after the overlay has been
applied) and not just the file from Mozilla, which is what you were showing.
Contact me via email to give you more instructions if you need them.

BTW. console2 is an extension. 

(In reply to comment #9)
> Current active addons:
> 
> Lightning 1.2.1
> Noia 2.0 eXtreme XT 3.36
> Quickfolders 2.12
> Quicktext 0.9.11.1
> Test Pilot for Thunderbird 1.3.5
> xSidebar for Thunderbird 0.8
> 
> That is all active addons
> 

Ok, I need the exact settings you have set on Nojia eXtreme XT. I think that is
doing something it shouldn't do. Also try what happens if you set the main
toolbar to icon without text? (And best restart Tb after that)

I still do not understand your screenshot. Where are your tabs? Are you looking
at a message in a new window? How do you get to the message in the view
(without any folder tree, but also not in a tab? I will posta a screenshot on
what it looks like on my system if I open a message in a new tab, and then what
it looks like if I open a message in its own window.

Created an attachment (id=7178) [details]
message in Tab

Showing Message in its own tab (using same theme as you). the current folder
toolbar is displayed above the message header. All buttons on the toolbar are
working

Created an attachment (id=7179) [details]
message in Window

showing the message in its own window: current message toolbar is not displayed
at all.

I tested by installing quickText, but that did not make any difference. I
already have Lightning  and Nojia xTreme installed. The only thing out of the
ordinay is your xSideBar 0.8 which is bot available on AMO (only 0.7 is), and
Mozilla's test pilot. COuld you disable these and restart to see whether it
changes anything?

Created an attachment (id=7180) [details]
QF 3.0 Prerelease 27

This is a test version. What happens when you right-click on the options button
(the cogwheel beside the close windows button). It should show the name of the
xul overlay that is currently active.

Also, can you try to open the options and by (normally) clicking the same
button, and then 
- click on the advanced tab
- uncheck the option "display the toolbar" uder Current Folder toolbar

In order to use QuickFolders you should probably also make the _main_
QuickFolders toolbar visible, using View > toolbars > QuickFolders toolbar

(In reply to comment #15)
> I tested by installing quickText, but that did not make any difference. I
> already have Lightning  and Nojia xTreme installed. The only thing out of the
> ordinay is your xSideBar 0.8 which is bot available on AMO (only 0.7 is), and
> Mozilla's test pilot. COuld you disable these and restart to see whether it
> changes anything?
> 

xSidebar 0.8 for Thunderbird is available on Mozdev:
http://xsidebar.mozdev.org/tsidebar/index.html

xSidebar 1.1 (and 1.2 alpha) for SeaMonkey is also available:
http://xsidebar.mozdev.org/installation.html

The author is Philip Chee, a SeaMonkey developer of excellent reputation.

Created an attachment (id=7181) [details]
debug menu showing which overlay is used

This screenshot shows the menu that pops up if you right click the options
button in the Prerelease27 posted previously; this is important as it will show
which version is overlayed. If it is the Tb10 version as expected and shown on
the screenshot, then the only way to finally further investigate the bug is by
looking at the individual elements in (and around) the toolbar, to see whether
any are modified with injected text.

Created an attachment (id=7182) [details]
Inspecting the Current Folder toolbar using DOMi

In order to investigate what is happening with the current folder toolbar and
the buttons on it, install DOMi (DOM inspector)

https://addons.mozilla.org/en-US/thunderbird/addon/dom-inspector-6622/

Press CTRL+SHIFT+i to start inspecting, and select 
File > Inspect Chrome Document > (title of your mail window)

Click the arrow button (find a node to inspect by clicking on it) and then
click on the current folder toolbar close button that is not working for you.

Left hand side is the DOM tree (the structure of all elements in the mail
window)
The right hand side shows the attributes of the button.

Investigating the buttons and their container(s) will tell me whether something
else manipulates the overlay in a way to break it. 

The screenshot shows the expected contents when you click on the close button -
note that there is no floating text element anywhere in the DOM tree within the 
QuickFolders-PreviewToolbarPanel box; within the toolbarbuttons there should
also be no additional elements except for images and labels, which you may see
displayed in red if you enable View>show anonymous content. You should not see
any TEXT elements within the QuickFolders-PreviewToolbarPanel box.

It appear that the xSideBar 0.8 is the culprit. I installed that because I have
had  persistent problem opening the contact pane when composing a new email.
Nobody has been able to resolve the issue so installing that resolved that
issue.

It never interfered with anything until I updated the browser and quickfolders.

Since I need to Bcc up to 40 club members monthly,I need the contact pane to do
that easily. It would be great if the address book would be able to Bcc a list. 

Should I close this and open a new bug issue to see if I can resolve the
contact pane issue?  

Maybe you could create a  bug with xSidebar, but you should definitely have a
look at your console2 output as well!!!

I can run xSidebar 0.8 without this problem happening, so it might be a
configuration issue. Also, where is your main QF toolbar? There is a new
version out soon, with that you can hide the current folder toolbar from the
options window, so that might be a temporary workaround.

Created an attachment (id=7219) [details]
New version with better overlays and configurable toolbar

This version fixes some overlay issues as I was able to reproduce the bug on Tb
11.01.

Also there is now a separate option on the advanced tab to show/hide the
current folder bar in the standalone Mail window. Tested in Tb 11.01, but
should be backwards compatible.

(In reply to comment #22)

Well I'll be. Everything now works properly. I will still look into what
started the problem to begin with.  


> Created an attachment (id=7219) [details] [details]
> New version with better overlays and configurable toolbar
> 
> This version fixes some overlay issues as I was able to reproduce the bug on Tb
> 11.01.
> 
> Also there is now a separate option on the advanced tab to show/hide the
> current folder bar in the standalone Mail window. Tested in Tb 11.01, but
> should be backwards compatible.
>